[PATCH] D89661: [llvm-objcopy][MachO] Fix the calculation of the output size
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 00:00:54 PDT 2020
alexshap added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp:125
+ if (S->isVirtualSection()) {
+ assert((S->Offset == 0) && "Virtual section's offset must be zero");
+ continue;
----------------
MaskRay wrote:
> virtual section is a LLVM specific abstraction. Probably use zerofill?
@MaskRay - are you referring to the message inside assert(...) ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89661/new/
https://reviews.llvm.org/D89661
More information about the llvm-commits
mailing list