[PATCH] D89661: [llvm-objcopy][MachO] Fix the calculation of the output size

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp:125
+      if (S->isVirtualSection()) {
+        assert((S->Offset == 0) && "Virtual section's offset must be zero");
+        continue;
----------------
alexshap wrote:
> MaskRay wrote:
> > virtual section is a LLVM specific abstraction. Probably use zerofill?
> @MaskRay - are you referring to the message inside assert(...) ?
Ah, yes. Though I think using "virtual" is fine as well, but in the Mach-O context it refers to specifically zerofill.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89661/new/

https://reviews.llvm.org/D89661