[PATCH] D89661: [llvm-objcopy][MachO] Fix the calculation of the output size
    Fangrui Song via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Oct 21 23:49:40 PDT 2020
    
    
  
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp:125
+      if (S->isVirtualSection()) {
+        assert((S->Offset == 0) && "Virtual section's offset must be zero");
+        continue;
----------------
virtual section is a LLVM specific abstraction. Probably use zerofill?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89661/new/
https://reviews.llvm.org/D89661
    
    
More information about the llvm-commits
mailing list