[PATCH] D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause

[Valentin Clement via Phabricator via llvm-commits]

clementval requested changes to this revision.
clementval added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:45
     std::int64_t associatedLoopLevel{0};
+    const parser::OmpClause *clause{nullptr};
   };
----------------
kiranchandramohan wrote:
> OmpClause should ideally be inside the OmpAttributeVistor. Is there any specific reason it should be here?
`OmpClause` should not be here. If this is intended to be shared with OpenACC it should be templated. 


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:77
   }
+  void SetContextAssociatedClause(const parser::OmpClause &c) {
+    GetContext().clause = &c;
----------------
Same here for `OmpClause` in generic part of `DirectiveAttributeVisitor`


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:80
+  }
+  const parser::OmpClause *GetContextAssociatedClause() {
+    return GetContext().clause;
----------------
Same here for `OmpClause` in generic part of `DirectiveAttributeVisitor`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89860/new/

https://reviews.llvm.org/D89860