[PATCH] D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Thanks for this patch. A few comments inline.



================
Comment at: flang/lib/Semantics/resolve-directives.cpp:45
     std::int64_t associatedLoopLevel{0};
+    const parser::OmpClause *clause{nullptr};
   };
----------------
OmpClause should ideally be inside the OmpAttributeVistor. Is there any specific reason it should be here?


================
Comment at: flang/test/Semantics/omp-do-collapse.f90:4
+! 2.7.1 Collapse Clause
+program omp_doCollapse
+  integer:: i,j
----------------
Can you add the following tests?
1) A positive test.
2) A positive test with more nested loops than the collapse value.
3) A negative test where there are loops enclosing the omp do loop with collapse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89860/new/

https://reviews.llvm.org/D89860