[PATCH] D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/check-directive-structure.h:199
+void DirectiveStructureChecker<D, C, PC, ClauseEnumSize>::
+    CheckObjectListStructure(const parser::OmpObjectList &objList) {
+
----------------
`OmpObjectList` is specific to OpenMP and doesn't fit in `check-directive-structure.h`


================
Comment at: flang/lib/Semantics/check-directive-structure.h:238
+
+          [&](const parser::Name &name) -> const parser::StructureComponent * {
+            return nullptr;
----------------
In the rest of Flang there is no blank line between each specific visitor so you might want to stick with the same coding style. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89395/new/

https://reviews.llvm.org/D89395