[PATCH] D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause

[Valentin Clement via Phabricator via llvm-commits]

clementval requested changes to this revision.
clementval added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Semantics/check-directive-structure.h:61
 
+  // OpenMP 4.5 : 2.15.3.2 and 2.15.3.3
+  const parser::StructureComponent *CheckAssociatedVariant(
----------------
Since this is OpenMP specific, it should be in check-omp-structure and not here.


================
Comment at: flang/lib/Semantics/check-directive-structure.h:66
+  // OpenMP 4.5 : 2.15.3.2 and 2.15.3.3
+  void CheckObjectListStructure(const parser::OmpObjectList &x);
+
----------------
Same here. Should be moved to check-omp-structure.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89395/new/

https://reviews.llvm.org/D89395