[PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

> Yes those are duplicate in a sense, but they are still tests(since nothing else is there) and can self validate well-formedness of the operation(which is one of the major pre-requisite for proceeding further with Lowering). 
> + They will ensure matches with community criteria. up-streaming in testable chunks.

My principal concern is that they do not test the code in `genACC` or `genOMP` so they won't catch any problem or regression there. I'm trying to put in place a unit test that make use of the `genACC` function directly. If that works I'll add the test before landing the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87389/new/

https://reviews.llvm.org/D87389