[PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX accepted this revision.
SouraVX added a comment.
This revision is now accepted and ready to land.

In D87389#2263915 <https://reviews.llvm.org/D87389#2263915>, @clementval wrote:

> In D87389#2263893 <https://reviews.llvm.org/D87389#2263893>, @SouraVX wrote:
>
>> Since `bbc` based test can't be added here, would you mind adding a unit-test here ?
>
> Well I have to see how to add a meaningful unit test here. Lowering unit tests that are currently upstreamed seem to just copy-paste the lowering code which does not really test the lowering code itself.

Yes those are duplicate in a sense, but they are still tests(since nothing else is there) and can self validate well-formedness of the operation(which is one of the major pre-requisite for proceeding further with Lowering). 
+ They will ensure matches with community criteria. up-streaming in testable chunks.

I do not have any strong reservations :). Feel free to merge, if you don't like the idea in general :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87389/new/

https://reviews.llvm.org/D87389