[PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

In D87389#2265571 <https://reviews.llvm.org/D87389#2265571>, @clementval wrote:

>> Yes those are duplicate in a sense, but they are still tests(since nothing else is there) and can self validate well-formedness of the operation(which is one of the major pre-requisite for proceeding further with Lowering). 
>> + They will ensure matches with community criteria. up-streaming in testable chunks.
>
> My principal concern is that they do not test the code in `genACC` or `genOMP` so they won't catch any problem or regression there. I'm trying to put in place a unit test that make use of the `genACC` function directly. If that works I'll add the test before landing the patch.

I think that is justified and already tested with full coverage in regression(end-to-end) test with `bbc`. 
The reason why I'm saying this that we(you) also don't want both branches going out-of-sync and regressing further development :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87389/new/

https://reviews.llvm.org/D87389