[PATCH] D80695: [mlir] Added big endian version of "dense-elements-hex.mlir"

Haruki Imai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 01:03:17 PDT 2020


imaihal added a comment.

In D80695#2262569 <https://reviews.llvm.org/D80695#2262569>, @mehdi_amini wrote:

> I don't understand what you're referring to right now: can you elaborate how a user would write the hex in BE?
> I expect a users to form the data in memory in BE on a BE machine, and then the printer will print in LE form always.

I thought native byte order should be written in `dense.attr`. (Users write BE HEX when they use BE machine) If this is not preferable, I think it would be better to describe it in MLIR specification.

Following link is just an example of ONNX.  
https://github.com/onnx/onnx/blob/3368834cf0b1f0ab9838cf6bdf78a27299d08187/onnx/onnx.in.proto#L538-L539


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80695/new/

https://reviews.llvm.org/D80695



More information about the llvm-commits mailing list