[PATCH] D80695: [mlir] Added big endian version of "dense-elements-hex.mlir"
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 10 12:10:49 PDT 2020
mehdi_amini added a comment.
In D80695#2265193 <https://reviews.llvm.org/D80695#2265193>, @imaihal wrote:
> I thought native byte order should be written in `dense.attr`.
Well that's my point all along: let's not do that and make the serialization/deserialization cross-platform.
> Users write BE HEX
Nit: users don't write HEX I believe, the MLIR printer does for them, and we control the printer I believe, at least for the standard types.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80695/new/
https://reviews.llvm.org/D80695
More information about the llvm-commits
mailing list