[PATCH] D80695: [mlir] Added big endian version of "dense-elements-hex.mlir"

[Alexandre Eichenberger via Phabricator via llvm-commits]

AlexEichenberger added a comment.

Just my two cents; LE vs BE typically gives problem when a program read data with one data size, and write data with another size. So if the reader in the dense attributes respect the type size, namely read and write the data using the same format, and then generate the hex directly from the register content, then there are no issues with endianness.

>From past optimizations, there are case when you want to write 64 bits at once, but later want to ready only 8 bits... then endianness is an issue as the program needs to know where to find the right 8 among the 64 in memory. But I don't think this is the case here, as the dense attributes are clearly typed and I see no reason not to read & write using the same one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80695/new/

https://reviews.llvm.org/D80695