[PATCH] D86952: [MIRVRegNamer] MachineInstr StableHashing.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 09:27:40 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineStableHash.h:1
+
+//===------------ MIRVRegNamerUtils.h - MIR VReg Renaming Utilities -------===//
----------------
Extra blank line


================
Comment at: llvm/lib/CodeGen/MIRVRegNamerUtils.cpp:66
+    assert(Hash && "Expected non-zero Hash");
+    return std::to_string(Hash).substr(0, 5);
+  }
----------------
Why substr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86952/new/

https://reviews.llvm.org/D86952



More information about the llvm-commits mailing list