[PATCH] D86952: [MIRVRegNamer] MachineInstr StableHashing.
Puyan Lotfi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 3 09:37:07 PDT 2020
plotfi marked an inline comment as done.
plotfi added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRVRegNamerUtils.cpp:66
+ assert(Hash && "Expected non-zero Hash");
+ return std::to_string(Hash).substr(0, 5);
+ }
----------------
arsenm wrote:
> Why substr?
Mostly because the existing hash (see end of the function) is a 5 char substring. Thanks for reviewing this @arsenm You think this should be a 7 char hash?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86952/new/
https://reviews.llvm.org/D86952
More information about the llvm-commits
mailing list