[PATCH] D86939: [LSR] Canonicalize a formula before insert it into the list

[Mindong Chen via Phabricator via llvm-commits]

mdchen added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/pr47329.ll:1
+; RUN: opt < %s -loop-reduce
+
----------------
qcolombet wrote:
> Could you add a check that we generate something sensible?
> (Not crashing is not a good enough check :))
I agree it's not good enough. However, the IR generated with assertions turned off is no difference with the one generated with this fix patch and I can't come up with reasonable checks here. I'd appreciate it if you can give some guidance :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86939/new/

https://reviews.llvm.org/D86939