[PATCH] D86939: [LSR] Canonicalize a formula before insert it into the list

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM, nitpicks below.



================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/pr47329.ll:1
+; RUN: opt < %s -loop-reduce
+
----------------
Could you add a check that we generate something sensible?
(Not crashing is not a good enough check :))


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/pr47329.ll:22
+for.body9.1:                                      ; preds = %for.inc.547, %for.body9.1
+  %1 = phi i32** [ %incdec.ptr.1, %for.body9.1 ], [ %incdec.ptr.542, %for.inc.547 ]
+  %incdec.ptr.1 = getelementptr inbounds i32*, i32** %1, i64 -1
----------------
Please get rid of the implicit variables (%[0-9]+). (You can use `opt -instnamer` for that.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86939/new/

https://reviews.llvm.org/D86939