[PATCH] D86940: [AMDGPU][MC] Corrected parser to avoid excessive error messages

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp created this revision.
dp added reviewers: rampitec, arsenm.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: LLVM.
dp requested review of this revision.
Herald added a subscriber: wdng.

Corrected parser to avoid generation of multiple messages for a single error.

Summary of changes:

- Changed parser to eliminate generation of excessive error messages;
- Corrected lit tests to match all expected error messages;
- Corrected lit tests to guard against unwanted extra messages (added option "--implicit-check-not=error:");
- Added missing checks and fixed some typos in tests.

Note that changes in gfx8_asm_all.s, gfx9_asm_all.s and gfx10_asm_all.s are not shown because the files are too large.

See bug 46907 <https://bugs.llvm.org/show_bug.cgi?id=46907>


https://reviews.llvm.org/D86940

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/SIDefines.h
  llvm/test/MC/AMDGPU/add-sub-no-carry.s
  llvm/test/MC/AMDGPU/atomic-fadd-insts.s
  llvm/test/MC/AMDGPU/buf-fmt-d16-packed.s
  llvm/test/MC/AMDGPU/buf-fmt-d16-unpacked.s
  llvm/test/MC/AMDGPU/dl-insts-err.s
  llvm/test/MC/AMDGPU/dpp-err.s
  llvm/test/MC/AMDGPU/ds-err.s
  llvm/test/MC/AMDGPU/ds-gfx9.s
  llvm/test/MC/AMDGPU/ds.s
  llvm/test/MC/AMDGPU/exp-err.s
  llvm/test/MC/AMDGPU/exp-gfx10.s
  llvm/test/MC/AMDGPU/expressions-gfx10.s
  llvm/test/MC/AMDGPU/expressions-gfx9.s
  llvm/test/MC/AMDGPU/expressions.s
  llvm/test/MC/AMDGPU/flat-gfx10.s
  llvm/test/MC/AMDGPU/flat-gfx9.s
  llvm/test/MC/AMDGPU/flat-global.s
  llvm/test/MC/AMDGPU/flat-scratch-instructions.s
  llvm/test/MC/AMDGPU/flat-scratch.s
  llvm/test/MC/AMDGPU/flat.s
  llvm/test/MC/AMDGPU/fma-mix.s
  llvm/test/MC/AMDGPU/gfx10-constant-bus.s
  llvm/test/MC/AMDGPU/gfx1011_err.s
  llvm/test/MC/AMDGPU/gfx1030_err.s
  llvm/test/MC/AMDGPU/gfx10_asm_dpp16.s
  llvm/test/MC/AMDGPU/gfx10_asm_dpp8.s
  llvm/test/MC/AMDGPU/gfx10_asm_err.s
  llvm/test/MC/AMDGPU/gfx10_asm_mimg_err.s
  llvm/test/MC/AMDGPU/gfx9-asm-err.s
  llvm/test/MC/AMDGPU/gfx9-vop2be-literal.s
  llvm/test/MC/AMDGPU/invalid-instructions-spellcheck.s
  llvm/test/MC/AMDGPU/lds_direct-err.s
  llvm/test/MC/AMDGPU/lds_direct-gfx10.s
  llvm/test/MC/AMDGPU/literal16-err.s
  llvm/test/MC/AMDGPU/literals.s
  llvm/test/MC/AMDGPU/literalv216-err.s
  llvm/test/MC/AMDGPU/literalv216.s
  llvm/test/MC/AMDGPU/mad-mix.s
  llvm/test/MC/AMDGPU/mai-err.s
  llvm/test/MC/AMDGPU/mai.s
  llvm/test/MC/AMDGPU/mimg-err.s
  llvm/test/MC/AMDGPU/mimg.s
  llvm/test/MC/AMDGPU/mtbuf-gfx10.s
  llvm/test/MC/AMDGPU/mtbuf.s
  llvm/test/MC/AMDGPU/mubuf-gfx9.s
  llvm/test/MC/AMDGPU/mubuf.s
  llvm/test/MC/AMDGPU/out-of-range-registers.s
  llvm/test/MC/AMDGPU/reg-syntax-err.s
  llvm/test/MC/AMDGPU/reg-syntax-extra.s
  llvm/test/MC/AMDGPU/regression/bug28538.s
  llvm/test/MC/AMDGPU/smem-err.s
  llvm/test/MC/AMDGPU/smem.s
  llvm/test/MC/AMDGPU/smrd-err.s
  llvm/test/MC/AMDGPU/smrd.s
  llvm/test/MC/AMDGPU/sop1-err.s
  llvm/test/MC/AMDGPU/sop1.s
  llvm/test/MC/AMDGPU/sop2-err.s
  llvm/test/MC/AMDGPU/sop2.s
  llvm/test/MC/AMDGPU/sopc-err.s
  llvm/test/MC/AMDGPU/sopc.s
  llvm/test/MC/AMDGPU/sopk-err.s
  llvm/test/MC/AMDGPU/sopk.s
  llvm/test/MC/AMDGPU/sopp-err.s
  llvm/test/MC/AMDGPU/sopp.s
  llvm/test/MC/AMDGPU/trap.s
  llvm/test/MC/AMDGPU/vintrp-err.s
  llvm/test/MC/AMDGPU/vop-err.s
  llvm/test/MC/AMDGPU/vop1-gfx9-err.s
  llvm/test/MC/AMDGPU/vop1-gfx9.s
  llvm/test/MC/AMDGPU/vop1.s
  llvm/test/MC/AMDGPU/vop2-err.s
  llvm/test/MC/AMDGPU/vop2.s
  llvm/test/MC/AMDGPU/vop3-convert.s
  llvm/test/MC/AMDGPU/vop3-errs.s
  llvm/test/MC/AMDGPU/vop3-gfx9.s
  llvm/test/MC/AMDGPU/vop3-literal.s
  llvm/test/MC/AMDGPU/vop3-modifiers-err.s
  llvm/test/MC/AMDGPU/vop3.s
  llvm/test/MC/AMDGPU/vop3p-err.s
  llvm/test/MC/AMDGPU/vop_dpp.s
  llvm/test/MC/AMDGPU/vop_sdwa.s
  llvm/test/MC/AMDGPU/vopc-errs.s
  llvm/test/MC/AMDGPU/vopc-vi.s
  llvm/test/MC/AMDGPU/wave32.s
  llvm/test/MC/AMDGPU/xdl-insts-err.s
  llvm/test/MC/AMDGPU/xnack-mask.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86940.289153.patch
Type: text/x-patch
Size: 471552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200901/cd379b73/attachment-0001.bin>