[PATCH] D86675: [ThinLTO] Fix a metadata lost issue with DICompileUnit import.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

AFAICT this looks ok, but adding @dblaikie as he is more familiar with the DI metadata. Couple minor comments below.



================
Comment at: llvm/test/ThinLTO/X86/import-metadata.ll:10
+;; Check the imported DICompileUnit doesn't have the enums operand.
+;; Also check the imported md metadta that shares a node with the 
+;; enums operand originally is not null.
----------------
s/metadta/metadata/


================
Comment at: llvm/test/ThinLTO/X86/import-metadata.ll:14
+; CHECK: !llvm.dbg.cu = !{![[#CU1:]], ![[#CU2:]]}
+; CHECK: !llvm.md = !{![[#MD1:]], ![[#MD2:]]}
+; CHECK: ![[#MD3:]] = !{}
----------------
Should these both be the same MD value? I don't see MD1 matched anywhere else


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86675/new/

https://reviews.llvm.org/D86675