[PATCH] D86675: [ThinLTO] Fix a metadata lost issue with DICompileUnit import.

[Hongtao Yu via Phabricator via llvm-commits]

hoy marked an inline comment as done.
hoy added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/import-metadata.ll:14
+; CHECK: !llvm.dbg.cu = !{![[#CU1:]], ![[#CU2:]]}
+; CHECK: !llvm.md = !{![[#MD1:]], ![[#MD2:]]}
+; CHECK: ![[#MD3:]] = !{}
----------------
tejohnson wrote:
> Should these both be the same MD value? I don't see MD1 matched anywhere else
Actually MD1 comes from the current module. MD2 is from the imported module. We are checking if the imported MD2 doesn't end up having a null operand MD3. Sorry for the confusion. I should make it more explicit.


================
Comment at: llvm/test/ThinLTO/X86/import-metadata.ll:38
+!4 = !{}
+!5 = !{!4, !4}
----------------
wenlei wrote:
> Just curious, any reason for `!5 = !{!4, !4}` instead of `!5 = !{!4}`?
Good point. One `!4` is just fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86675/new/

https://reviews.llvm.org/D86675