[PATCH] D86675: [ThinLTO] Fix a metadata lost issue with DICompileUnit import.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 08:52:58 PDT 2020


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

LGTM. @tejohnson appreciate if you could take a look too, thanks. (this is blocking an internal usage for us)



================
Comment at: llvm/test/ThinLTO/X86/import-metadata.ll:38
+!4 = !{}
+!5 = !{!4, !4}
----------------
Just curious, any reason for `!5 = !{!4, !4}` instead of `!5 = !{!4}`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86675/new/

https://reviews.llvm.org/D86675



More information about the llvm-commits mailing list