[PATCH] D86664: [GlobalISel] Rewrite the elide-br-by-swapping-icmp-ops combine to do less.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 12:09:11 PDT 2020


aemerson added a comment.

In D86664#2240598 <https://reviews.llvm.org/D86664#2240598>, @arsenm wrote:

> The IRTranslator chooses to omit the  G_BR if it can use a fallthrough. Should it not do that either, and the verifier enforce always having G_BR and G_BRCOND?

I think this is a reasonable idea. We discussed this a long time ago internally but ultimately didn't have any strong opinions to change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86664/new/

https://reviews.llvm.org/D86664



More information about the llvm-commits mailing list