[PATCH] D86664: [GlobalISel] Rewrite the elide-br-by-swapping-icmp-ops combine to do less.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:720
+
+APInt llvm::getICmpTrueVal(const TargetLowering &TLI, LLT Ty) {
+  assert(Ty.isScalar() && "Expected a scalar type only");
----------------
arsenm wrote:
> Not sure there's much point in using APInt here?
I've moved this function to an earlier patch and changed it to use int64_t instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86664/new/

https://reviews.llvm.org/D86664