[PATCH] D86664: [GlobalISel] Rewrite the elide-br-by-swapping-icmp-ops combine to do less.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

In D86664#2242821 <https://reviews.llvm.org/D86664#2242821>, @aemerson wrote:

> In D86664#2240598 <https://reviews.llvm.org/D86664#2240598>, @arsenm wrote:
>
>> The IRTranslator chooses to omit the  G_BR if it can use a fallthrough. Should it not do that either, and the verifier enforce always having G_BR and G_BRCOND?
>
> I think this is a reasonable idea. We discussed this a long time ago internally but ultimately didn't have any strong opinions to change it.

My main question for this is: Where would we handle the fallthrough cases for this? It's common enough that I'd prefer it to be somewhere target independent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86664/new/

https://reviews.llvm.org/D86664