[PATCH] D86664: [GlobalISel] Rewrite the elide-br-by-swapping-icmp-ops combine to do less.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D86664#2240598 <https://reviews.llvm.org/D86664#2240598>, @arsenm wrote:

> The IRTranslator chooses to omit the  G_BR if it can use a fallthrough. Should it not do that either, and the verifier enforce always having G_BR and G_BRCOND?





================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:917
+  auto &MF = Builder.getMF();
+  const auto &TLI = *MF.getSubtarget().getTargetLowering();
 
----------------
Should be able to get ths from MachinEIRBuilder now


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:720
+
+APInt llvm::getICmpTrueVal(const TargetLowering &TLI, LLT Ty) {
+  assert(Ty.isScalar() && "Expected a scalar type only");
----------------
Not sure there's much point in using APInt here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86664/new/

https://reviews.llvm.org/D86664