[PATCH] D86296: [flang][openacc] Fix reduction operator parsing/unparsing

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 07:42:55 PDT 2020


clementval added a comment.

In D86296#2230456 <https://reviews.llvm.org/D86296#2230456>, @kiranchandramohan wrote:

> Would you have issues matching the operation in Fortran and the reduction operation in the OpenACC directive since you are using your own custom enums?

I'm not sure I get what you want to say here.



================
Comment at: flang/include/flang/Parser/parse-tree.h:3846
+  WRAPPER_CLASS_BOILERPLATE(AccReductionOperator, Operator);
+  CharBlock source;
 };
----------------
kiranchandramohan wrote:
> For my information: Why is source needed here?
Just to hold the source location information for error reporting. So error can be reported on the reduction operator. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86296/new/

https://reviews.llvm.org/D86296



More information about the llvm-commits mailing list