[PATCH] D86296: [flang][openacc] Fix reduction operator parsing/unparsing
Kiran Chandramohan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 06:56:20 PDT 2020
kiranchandramohan added a comment.
LGTM. But because this is different from OpenMP handling it will be best if @klausler or @sscalpone approves.
Would you have issues matching the operation in Fortran and the reduction operation in the OpenACC directive since you are using your own custom enums?
================
Comment at: flang/include/flang/Parser/parse-tree.h:3846
+ WRAPPER_CLASS_BOILERPLATE(AccReductionOperator, Operator);
+ CharBlock source;
};
----------------
For my information: Why is source needed here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86296/new/
https://reviews.llvm.org/D86296
More information about the llvm-commits
mailing list