[PATCH] D86296: [flang][openacc] Fix reduction operator parsing/unparsing

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

In D86296#2230534 <https://reviews.llvm.org/D86296#2230534>, @clementval wrote:

> In D86296#2230456 <https://reviews.llvm.org/D86296#2230456>, @kiranchandramohan wrote:
>
>> Would you have issues matching the operation in Fortran and the reduction operation in the OpenACC directive since you are using your own custom enums?
>
> I'm not sure I get what you want to say here.

What I meant to say here is that previously the OpenACCReductionOperator was defined in terms of struct DefinedOperator which in turn is defined in terms of DefinedOpName or IntrinsicOperator. If these are also used for the Fortran expressions in the parse tree then it is easy to match the OpenACC Reduction Operation and the operation in Fortran source where reduction is implied. If you use your own custom definitions for operations then there is some code that you have to write to do the matching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86296/new/

https://reviews.llvm.org/D86296