[PATCH] D86296: [flang][openacc] Fix reduction operator parsing/unparsing

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D86296#2228691 <https://reviews.llvm.org/D86296#2228691>, @kiranchandramohan wrote:

> Sorry, I have not gone into detail here. But could you provide some motivation/explanation for this change? Is this because OpenACC accepts fewer or different reduction operators. Or is a similar change required in OpenMP too.

In the current state, only reduction with `+` and `*` would be parsed and resolved correctly. We would need a intrinsic function name resolution in place to accept the others operators and also a semantic check to discard all intrinsic that are not accepted as reduction operator. So in order to simply thing, a simple enumeration seemed a better replacement. OpenACC doesn't accept user-defined reduction operator so we can make this simplification. For OpenMP, as you can use user-defined operator I guess you will have to put in place a function name resolution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86296/new/

https://reviews.llvm.org/D86296