[PATCH] D85664: [SampleFDO] Stop letting findCalleeFunctionSamples return unrelated profiles for invoke instructions
Wei Mi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 10:50:24 PDT 2020
wmi added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:819
if (!DIL) {
return nullptr;
}
----------------
hoyFB wrote:
> Does it return here for invokes that don't have debug info?
>
> The fix looks good to me. We should not treat non-call instructions are indirect calls.
No it doesn't. The invoke instruction has debug information. It is the definition of the function being invoked doesn't have debug information.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85664/new/
https://reviews.llvm.org/D85664
More information about the llvm-commits
mailing list