[PATCH] D85664: [SampleFDO] Stop letting findCalleeFunctionSamples return unrelated profiles for invoke instructions

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 10:47:15 PDT 2020


hoyFB accepted this revision.
hoyFB added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:819
   if (!DIL) {
     return nullptr;
   }
----------------
Does it return here for invokes that don't have debug info?

The fix looks good to me. We should not treat non-call instructions are indirect calls.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85664/new/

https://reviews.llvm.org/D85664



More information about the llvm-commits mailing list