[PATCH] D85664: [SampleFDO] Stop letting findCalleeFunctionSamples return unrelated profiles for invoke instructions

[Hongtao Yu via Phabricator via llvm-commits]

hoyFB added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:819
   if (!DIL) {
     return nullptr;
   }
----------------
wmi wrote:
> hoyFB wrote:
> > Does it return here for invokes that don't have debug info?
> > 
> > The fix looks good to me. We should not treat non-call instructions are indirect calls.
> No it doesn't. The invoke instruction has debug information. It is the definition of the function being invoked doesn't have debug information.
Oh I see. Thanks for the fix!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85664/new/

https://reviews.llvm.org/D85664