[PATCH] D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl marked an inline comment as done.
rahmanl added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:479
+  /// Returns the MCSymbol marking the end of this basic block.
+  MCSymbol *getEndSymbol() const;
+
----------------
shenhan wrote:
> If all usage of getEndSymbol() accept a const version of "MCSymbol *", maybe change it to "const MCSymbol *" that goes along with the const nature of the function.
Unfortunately, that's not the case. MCObjectStreamer::emitLabel takes a non-const reference to a symbol (and actually mutates the symbol).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83885/new/

https://reviews.llvm.org/D83885