[PATCH] D80750: llvm-link: Add module flag behavior MergeTargetID

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 10:08:41 PDT 2020


yaxunl added a comment.

In D80750#2160567 <https://reviews.llvm.org/D80750#2160567>, @jdoerfert wrote:

> > Except for the id string, all feature strings end with '+' or '-'.
>
> Except for the triple string you mean?


should be triple-cpu string.

> What is the difference to the `"target-features"` attribute we have? Shouldn't we use the same encoding instead of inventing yet another one?

In the future, target ID may introduce key=value entries. Let the key before value will make it consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80750/new/

https://reviews.llvm.org/D80750





More information about the llvm-commits mailing list