[PATCH] D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block.

Han Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 10:07:34 PDT 2020


shenhan added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:479
+  /// Returns the MCSymbol marking the end of this basic block.
+  MCSymbol *getEndSymbol() const;
+
----------------
If all usage of getEndSymbol() accept a const version of "MCSymbol *", maybe change it to "const MCSymbol *" that goes along with the const nature of the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83885/new/

https://reviews.llvm.org/D83885





More information about the llvm-commits mailing list