[PATCH] D83995: Provide some instructions to guide the user on how to get a more up-to-date CMake in CMake error message
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 17 19:08:54 PDT 2020
mehdi_amini added a comment.
In D83995#2158804 <https://reviews.llvm.org/D83995#2158804>, @ctetreau wrote:
> I think a change such as this would be an improvement. However, I think the linux special case is encouraging bad security habits "wget this random binary and run it!", and IMO should be removed.
Do you mean the non-linux special case? The linux special case does not download a binary but the sources, and also explicitly check the checksum.
> I would also provide the download link from cmake.org rather than github. This is more robust in the face of kitware changing their repo hosting site (the github repo that you linked is not even the real repo, it's a mirror)
Look good, I'll update to https://cmake.org/download/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83995/new/
https://reviews.llvm.org/D83995
More information about the llvm-commits
mailing list