[PATCH] D83995: Provide some instructions to guide the user on how to get a more up-to-date CMake in CMake error message

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 09:47:41 PDT 2020


ctetreau added a comment.

I think a change such as this would be an improvement. However, I think the linux special case is encouraging bad security habits "wget this random binary and run it!", and IMO should be removed.

I would also provide the download link from cmake.org rather than github. This is more robust in the face of kitware changing their repo hosting site (the github repo that you linked is not even the real repo, it's a mirror)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83995/new/

https://reviews.llvm.org/D83995





More information about the llvm-commits mailing list