[PATCH] D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC

Fri Jul 17 09:57:10 PDT 2020

NeHuang marked 2 inline comments as done.
NeHuang added inline comments.

================
Comment at: lld/ELF/Arch/PPC64.cpp:113
+}
+
 static bool addOptional(StringRef name, uint64_t value,
----------------
stefanp wrote:
> NeHuang wrote:
> > stefanp wrote:
> > > nit: Why was this moved up and the comment deleted?
> > > I assume it was something that the rebase did...
> > The comment was moved to (line 216) in `lld/ELF/Target.h`  when I added the function declaration there. 
> Ok, see that the comment was moved.
> Why was the function moved up?
I moved it up to group the functions declared in `lld/ELF/Target.h` (following declaration order)  Also separated from the static functions below. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83504/new/

https://reviews.llvm.org/D83504