[PATCH] D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC

Fri Jul 17 10:14:04 PDT 2020

NeHuang marked 2 inline comments as done.
NeHuang added inline comments.

================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-toc.s:2
+# REQUIRES: ppc
+# RUN: echo 'SECTIONS { \
+# RUN:   .text_func   0x10010000 : { *(.text_func) } \
----------------
MaskRay wrote:
> Do you mind adopting https://reviews.llvm.org/D83834#change-qrppZgZj6Chf ?
Thanks MaskRay for the input! The new style looks better. Howvever, seems your patch has not landed it yet. : )
I tried applying your changes locally to use `extract` in this case and confirmed it passed. 
To avoid introducing dependency, I prefer keeping the old style in this patch and starting using the new style once your patch committed. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83504/new/

https://reviews.llvm.org/D83504