[PATCH] D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

I only had one question.
Otherwise, LGTM.

However, please wait for approval from sfertile and/or MaskRay before committing.



================
Comment at: lld/ELF/Arch/PPC64.cpp:113
+}
+
 static bool addOptional(StringRef name, uint64_t value,
----------------
NeHuang wrote:
> stefanp wrote:
> > nit: Why was this moved up and the comment deleted?
> > I assume it was something that the rebase did...
> The comment was moved to (line 216) in `lld/ELF/Target.h`  when I added the function declaration there. 
Ok, see that the comment was moved.
Why was the function moved up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83504/new/

https://reviews.llvm.org/D83504