[PATCH] D83137: [SVE][CodeGen] Legalisation of masked loads and stores

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin marked 3 inline comments as done.
kmclaughlin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7135
   if (IsCompressedMemory) {
+    assert(!DataVT.isScalableVector() &&
+           "Cannot currently handle compressed memory with scalable vectors");
----------------
david-arm wrote:
> Do we know if this is something we catch earlier and hence should never get here? I just wonder if here it's not really an assert that something went wrong with the code, but perhaps we just hit a case we don't support yet? If it's just because we don't support it yet, instead of asserting we could do:
> 
> if (DataVT.isScalableVector())
>   report_fatal_error("Cannot currently handle compressed memory with scalable vectors");
I think this is something that we just don't support yet, so I've changed this to `report_fatal_error` as suggested


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83137/new/

https://reviews.llvm.org/D83137