[PATCH] D83243: [ELF] Rename canRelax to sharedToExecRelax. NFC
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 09:25:07 PDT 2020
MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
================
Comment at: lld/ELF/Relocations.cpp:311
R_TLSIE_HINT>(expr) &&
- canRelax && isLocalInExecutable) {
+ sharedToExecRelax && isLocalInExecutable) {
c.relocations.push_back({R_RELAX_TLS_IE_TO_LE, type, offset, addend, &sym});
----------------
Initial-Exec -> Local-Exec is a relaxation from executable to executable. `sharedToExecRelax` is not an appropriate name. Shall we rename the variable?
Technically, a shared object can use Initial-Exec as well if it is part of initial modules (via transitive DT_NEEDED; `DF_STATIC_TLS`).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83243/new/
https://reviews.llvm.org/D83243
More information about the llvm-commits
mailing list