[PATCH] D83243: [ELF] Rename canRelax to sharedToExecRelax. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 09:20:07 PDT 2020


MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:211
   // DTPMOD may not be expected at load time.
   bool isLocalInExecutable = !sym.isPreemptible && !config->shared;
 
----------------
grimar wrote:
> It looks like we can get rid of this variable now? I.e. looks like `isLocalInExecutable` can be replaced with `!sym.isPreemptible` everywhere.
We can't delete it.

```
if (!sharedToExecRelax) {
  // if (isLocalInExecutable)
  // cannot be changed to
  // if (!sym.isPreemptible
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83243/new/

https://reviews.llvm.org/D83243





More information about the llvm-commits mailing list