[PATCH] D83243: [ELF] Rename canRelax to sharedToExecRelax. NFC

[Peter Smith via Phabricator via llvm-commits]

psmith added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:311
             R_TLSIE_HINT>(expr) &&
-      canRelax && isLocalInExecutable) {
+      sharedToExecRelax && isLocalInExecutable) {
     c.relocations.push_back({R_RELAX_TLS_IE_TO_LE, type, offset, addend, &sym});
----------------
MaskRay wrote:
> Initial-Exec -> Local-Exec is a relaxation from executable to executable. `sharedToExecRelax` is not an appropriate name. Shall we rename  the variable?
> 
> Technically, a shared object can use Initial-Exec as well if it is part of initial modules (via transitive DT_NEEDED; `DF_STATIC_TLS`).
Perhaps just toExecRelax or canExecRelax?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83243/new/

https://reviews.llvm.org/D83243