[PATCH] D83243: [ELF] Rename canRelax to sharedToExecRelax. NFC

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 01:46:29 PDT 2020


grimar accepted this revision.
grimar added a comment.

LGTM too. A question/suggestion for a follow-up is inlined.



================
Comment at: lld/ELF/Relocations.cpp:211
   // DTPMOD may not be expected at load time.
   bool isLocalInExecutable = !sym.isPreemptible && !config->shared;
 
----------------
It looks like we can get rid of this variable now? I.e. looks like `isLocalInExecutable` can be replaced with `!sym.isPreemptible` everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83243/new/

https://reviews.llvm.org/D83243





More information about the llvm-commits mailing list