[PATCH] D82816: [LLD][PowerPC] Implement R_PPC64_REL24_NOTOC calls, callee also has no TOC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:1043
+  // FIXME: Remove the assertions once the call protocols are supported.
+  assert(!(type == R_PPC64_REL24_NOTOC && (s.stOther >> 5) > 1) &&
+         "Unsupported protocol: RelType is R_PPC64_REL24_NOTOC and the callee "
----------------
Note: assert should only be used for logically unreachable code, i.e. if the implementation is not buggy, the negative code path should not trigger.

You can use `fatal(...)` for unimplemented features. Please use all lowercase messages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82816/new/

https://reviews.llvm.org/D82816