[PATCH] D82816: [LLD][PowerPC] Implement R_PPC64_REL24_NOTOC calls, callee also has no TOC

[Victor Huang via Phabricator via llvm-commits]

NeHuang updated this revision to Diff 275896.
NeHuang added a comment.

Thanks @sfertile and @stefanp for the review!

To Sean's question on the test coverage in this patch:

  Yes, your understand is correct. 

Addressed the review comments:

- Clang-format line 1039 in `lld/ELF/Arch/PPC64.cpp`
- Inserted fatal errors for the unsupported call protocols and notoc thunks.
- Condense the 4 lit cases into 1 lit test with an input file.
- Added another lit test with an input file for `callee` with hidden visibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82816/new/

https://reviews.llvm.org/D82816

Files:
  lld/ELF/Arch/PPC64.cpp
  lld/ELF/Thunks.cpp
  lld/test/ELF/Inputs/ppc64-extern-callee-hidden.s
  lld/test/ELF/Inputs/ppc64-extern-callee.s
  lld/test/ELF/ppc64-pcrel-call-to-pcrel-callee-hidden.s
  lld/test/ELF/ppc64-pcrel-call-to-pcrel.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82816.275896.patch
Type: text/x-patch
Size: 15601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200707/1258d9a2/attachment.bin>