[PATCH] D82816: [LLD][PowerPC] Implement R_PPC64_REL24_NOTOC calls, callee also has no TOC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel-callee-hidden.s:22
+
+# SYMBOL: 1: 000000001001000c 0 NOTYPE LOCAL DEFAULT [<other: 0x20>] 5 caller1
+# SYMBOL-NEXT: 2: 0000000010010028 0 NOTYPE LOCAL DEFAULT [<other: 0x20>] 5 caller1_tailcall
----------------
Align `1: `


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel.s:20
+# RUN: llvm-objdump -d --no-show-raw-insn --mcpu=pwr10 %t | FileCheck %s
+
+
----------------
One empty line is sufficient.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel.s:22
+
+# SYMBOL: 1: 0000000010010000 0 NOTYPE LOCAL DEFAULT 1 callee1_stother0_local
+# SYMBOL-NEXT: 2: 000000001002000c 0 NOTYPE LOCAL DEFAULT [<other: 0x20>] 2 callee2_stother1_local
----------------
Indent the first line


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel.s:40
+# CHECK-NEXT: 10010000: mullw 3, 3, 3
+# CHECK: 10010008: blr
+
----------------
Make addresses indented.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel.s:42
+
+# CHECK-LABEL: caller1
+# CHECK: 10010018: bl 0x10010000
----------------
`caller1` is not a good FileCheck label.

`<caller1>:` is. It is unique in the llvm-objdump output.

Please fix all the occurrences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82816/new/

https://reviews.llvm.org/D82816