[PATCH] D83275: [llc] (almost) remove `--print-machineinstrs`

Tue Jul 7 09:08:54 PDT 2020

dsanders added a comment.

In D83275#2134966 <https://reviews.llvm.org/D83275#2134966>, @ychen wrote:

> In D83275#2134936 <https://reviews.llvm.org/D83275#2134936>, @dsanders wrote:
>
> > I was worried for a moment that we'd be losing the ability to print between all machine passes but it looks like -print-after-all covers that now (I don't think that was always the case). So long as we aren't losing any inter-pass dumps this LGTM but I'd suggest giving it a few days to see if anyone was using this in a way that isn't evident from the tests.
> >
> > > -print-after/-stop-after since isel pass does not have commandline name.
> >
> > IIRC, there's something weird going on in this area. I vaguely remember a problem I never got to the bottom of where there was no name when AMDGPU was omitted but when it was compiled, everybody's pass was called `amdgpu-isel`. It had something to do with AMDGPU needing additional dependencies and using INITIALIZE_PASS to get them.
>
>
> I don't know if it is the cause but AMDGPUDAGToDAGISel::ID is actually SelectionDAGISel::ID.

That could be it. Those ID's are the keys into the pass registry so that would cause AMDGPUDAGToDAGISel to register a PassInfo for SelectionDAGISel with the argument "amdgpu-isel" which would be how other targets are able to use it. Without it compiled in, there would be no PassInfo registered leaving getPassIDFromName() unable to find it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83275/new/

https://reviews.llvm.org/D83275