[PATCH] D82387: [flang] add RTBuilder

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 14:40:09 PDT 2020


Agreed. This should be fixed :)

-eric

On Mon, Jul 6, 2020 at 12:54 PM David Truby via Phabricator <
reviews at reviews.llvm.org> wrote:

> DavidTruby added a comment.
>
> Is there a reason to use `float _Complex` here at all? The C++ standard
> (29.5.4 of C++17) guarantees that `std::complex<float>` and `float
> _Complex` are layout compatible and can be reinterpret_casted to each other
> so even if these functions are intended to be callable from C/interoperable
> with _Complex in C code, it'd be better to use std::complex<float> on the
> C++ side.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D82387/new/
>
> https://reviews.llvm.org/D82387
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200706/e82cdcdb/attachment.html>


More information about the llvm-commits mailing list